Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pa11y and lighthouse a11y testing to workflows #991

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

nwanduka
Copy link
Contributor

@nwanduka nwanduka commented Jul 1, 2024

Summary

Created pa11y.yml and lighthouse.yml to complement the already existing axe a11y testing tool in workflows

Motivation

Testing

Questions

@nwanduka nwanduka marked this pull request as ready for review July 4, 2024 12:53
@birm
Copy link
Member

birm commented Jul 5, 2024

Am I reading the lighthouse report correctly that it seems to be stuck at the redirect?

@nwanduka
Copy link
Contributor Author

nwanduka commented Jul 8, 2024

Am I reading the lighthouse report correctly that it seems to be stuck at the redirect?

Yep! That's the issue I meant when I said it wasn't testing all the pages. I wonder why that is.

@birm
Copy link
Member

birm commented Jul 9, 2024

It looks like it's not following links or anything of the sort. Do we need to give it a list of urls?

@nwanduka
Copy link
Contributor Author

No, I don't think we need to provide it with a list of URLs. According to the docs, Lighthouse will "automatically find your project's static assets, run Lighthouse 3 times on each HTML file, and upload the reports to temporary public storage where they'll be accessible to anyone with the URL."

@nwanduka nwanduka marked this pull request as draft July 25, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants