Improve errors received when creating an endpoint #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mostly improves testing and code organization, it does not fix anything
|
@vprintempsPei this should address the issue raised in #82 in a more future-proof way, could you please confirm? |
This allows having proper error instances on the main thread instead of generic Error instances
|
@vprintempsPei I'm going to merge this and cut the 1.2.0 release, let me know if you see something else missing, thanks a lot for your contributions! |
|
Hello, thanks for this big work ! i will try the implementation today. I let you know ! |
|
Hello, I implemented it yersteday and it works fine and allows us to improve the error management. Thank you. |
|
Great news! thanks. I'm going to do the 1.2.0 release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure that errors raised in the worker are reproduced identically on the main thread. Before, all errors were transformed to a generic
Errorinstance because of serialization.Also adds some more testing on the endpoints.