Skip to content
This repository has been archived by the owner on Apr 8, 2024. It is now read-only.

Commit

Permalink
0.20.0 release + timeout boolean (#59)
Browse files Browse the repository at this point in the history
0.20.0 release + timeout boolean
  • Loading branch information
s3than authored Jul 17, 2019
2 parents ef3f532 + 5dcf359 commit 8e81c16
Show file tree
Hide file tree
Showing 7 changed files with 11 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
test:
docker:
- image: circleci/node:11.10.1
- image: sitapati/zeebe:0.20.0
- image: camunda/zeebe:0.20.0
working_directory: ~/zeebe-client-node-js
steps:
- checkout
Expand Down
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ Docker-compose configurations for Zeebe are available at [https://github.com/zee

To enable that the client libraries can be easily supported to the Zeebe server we are remapping the version numbers, so that Major, Minor match the server application. Patches will be independent and indicate client updates.

NPM Package version 0.20.x supports Zeebe 0.20.x

NPM Package version 0.19.x supports Zeebe 0.19.x

NPM Package version 2.x.x supports Zeebe 0.18.
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "zeebe-node",
"version": "v0.19.3",
"version": "v0.20.0",
"description": "A Node.js client library for the Zeebe Microservices Orchestration Engine.",
"keywords": [
"zeebe",
Expand Down
3 changes: 2 additions & 1 deletion src/__tests__/integration/ZBClient-integration.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,8 @@ describe('ZBClient', () => {
attempts++
// Succeed on the third attempt
if (attempts === 3) {
return complete()
complete()
return
}
complete.failure('Triggering a retry')
if (attempts === 2) {
Expand Down
2 changes: 1 addition & 1 deletion src/lib/GRPCClient.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export class GRPCClient {

for (const key in listMethods) {
if (listMethods[key]) {
const methodName = listMethods[key].originalName
const methodName = listMethods[key].originalName as string
this.listNameMethods.push(methodName)

this[`${methodName}Async`] = (data, fnAnswer) => {
Expand Down
4 changes: 2 additions & 2 deletions src/lib/interfaces.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ export interface KeyedObject {
export type Loglevel = 'INFO' | 'DEBUG' | 'NONE' | 'ERROR'

export interface CompleteFn<WorkerOutputVariables> {
(updatedVariables?: Partial<WorkerOutputVariables>): void
success: (updatedVariables?: Partial<WorkerOutputVariables>) => void
(updatedVariables?: Partial<WorkerOutputVariables>): boolean
success: (updatedVariables?: Partial<WorkerOutputVariables>) => boolean
failure: (errorMessage: string, retries?: number) => void
}

Expand Down
2 changes: 2 additions & 0 deletions src/zb/ZBWorker.ts
Original file line number Diff line number Diff line change
Expand Up @@ -261,10 +261,12 @@ export class ZBWorker<
this.logger.debug(
`Completed task ${taskId} for ${this.taskType}`
)
return true
} else {
this.logger.debug(
`Completed task ${taskId} for ${this.taskType}, however it had timed out.`
)
return false
}
}
shadowWorkerCallback.success = shadowWorkerCallback
Expand Down

0 comments on commit 8e81c16

Please sign in to comment.