Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Handle escape and regex characters #930

Merged
merged 4 commits into from
Sep 25, 2024
Merged

fix: Handle escape and regex characters #930

merged 4 commits into from
Sep 25, 2024

Commits on Sep 24, 2024

  1. refactor: Use parameterized test case

    @saig0
    saig0 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    c8b01bd View commit details
    Browse the repository at this point in the history

  2. refactor: Combine test cases

    @saig0
    saig0 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    58efca9 View commit details
    Browse the repository at this point in the history

  3. test: Verify string literal with regex characters

    @saig0
    saig0 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    544c038 View commit details
    Browse the repository at this point in the history

  4. fix: Handle escape sequences 

    Correct the handling of escape sequences in string literals.

Don't replace escape sequences in regex expressions, for example, \r or \n. In the parser, these sequences start with \\. Same for \s, don't replace it with a whitespace, since this is also a part of a regex.

Handle \\ to avoid that the sequence is escaped and returned as \\\\.
    @saig0
    saig0 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    d266e80 View commit details
    Browse the repository at this point in the history