fix: A unary-test expression with ? returns true/false #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a test case to verify an unary-tests expression with the special variable `?` for a parameter with ANY type.
Check if a function argument is an error before invoking the function. Otherwise, the function may handle the argument not as an error but a regular value.
Move the function validation in the interpreter before invoking the function.
saig0
added
backport 1.17
backport 1.18
backport 1.16
backport 1.19
and removed
backport 1.16
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The engine restricts the usage of
?to an unary-test expression. It is implemented by returning aValFatalErrorwhen accessing?. If the expression is a unary-test, it evaluates the expression again and assigns the input value to?.Previously, the engine invoked a function without checking the arguments before. As a result, a function with an
Anyparameter (e.g.list contains(list, any)) accepted aValError/ValFatalErroras a regular value and didn't forward the error.Fix the issue by adding the validation of the arguments before invoking the function.
Related issues
closes camunda/camunda#26054