Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated dependencies: SSSOM.py #33

Merged

Conversation

joeflack4
Copy link
Collaborator

@joeflack4 joeflack4 commented Jul 15, 2021

Related to

Issues: #28, #30, #32

Pull requests

Changes

Updated dependencies
- SSSOM.py: Locked in to a specific commit that currently works for us, following a PR that recently fixed the [linkml/linkml_runtime].utils related issue. Future development will probably break this dependency for us, so good to lock in now.
- ordered-set: Switched from CPython-based non-precompiled 'orderedset' to pure Python-based 'ordered-set' functionality. The API seems similar / same, and should be especially OK to do this because it doesn't look like this it's being used yet in the project.

Potential improvements TODO

I didn't update the lockfile. Still working on that.

@joeflack4 joeflack4 force-pushed the bugfix_dependencies-ordredset-sssom branch from acb6291 to c64b75e Compare July 16, 2021 18:13
- SSSOM.py: Locked in to a specific commit that currently works for us, following a PR that recently fixed the [linkml/linkml_runtime].utils related issue. Future development will probably break this dependency for us, so good to lock in now.
@joeflack4 joeflack4 force-pushed the bugfix_dependencies-ordredset-sssom branch from c64b75e to 63add22 Compare July 16, 2021 18:17
@joeflack4 joeflack4 changed the title Updated dependencies: SSSOM.py && ordered-set Updated dependencies: SSSOM.py Jul 16, 2021
@jiaola jiaola merged commit f546c48 into cancerDHC:master Jul 16, 2021
@joeflack4 joeflack4 deleted the bugfix_dependencies-ordredset-sssom branch July 19, 2021 22:23
@joeflack4 joeflack4 mentioned this pull request Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants