Use 1-indexing for exon numbers in convert coordinates #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katiestahl
reviewed
Oct 3, 2024
| @@ -254,13 +254,13 @@ const GetCoordinates: React.FC = () => { | |||
| {genomicEnd != null ? renderRow("Genomic end", genomicEnd) : null} | |||
| {renderRow("Transcript", results.tx_ac)} | |||
| {txSegStart?.exon_ord != null | |||
| ? renderRow("Exon start", txSegStart.exon_ord) | |||
| ? renderRow("Exon start", txSegStart.exon_ord + 1) | |||
There was a problem hiding this comment.
do we append 1 to the Tx Segment elements for these as well? If not but the behavior is different, we might want to take a look at if we should fix this in fusor instead
There was a problem hiding this comment.
So the JSON output represents the exon numbers using 0-indexing, but since the human-readable nomenclature string that populates above the Transcript Segment Element uses 1-indexing, I thought it would be good to use 1-indexing in this case since the convert coordinates output is also human readable
korikuzma
requested changes
Oct 4, 2024
client/src/components/Utilities/GetCoordinates/GetCoordinates.tsx
Outdated
Show resolved
Hide resolved
katiestahl
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #340