-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use latest conceptual framework for transcipt segment start/end #171
Comments
@ahwagner Requesting your thoughts on this to confirm that we are accurately interpreting the correct use of |
I landed here per #166 (comment) during review. Would you be able to link the working docs / examples referenced in this issue for comment? |
Offhand, there's an initial illustration of how to think about orientation here -- https://docs.google.com/document/d/1EE1-evt6NStIKUENWdirR9lXo6rtBhQvCUxvxaGYlXs/edit from Jeremy. I believe he's also writing up something a bit bigger as well. p.s. relaying in-person discussion -- plan is to produce a draft with examples and refer to ahwagner for review at that point |
@ahwagner @jarbesfeld and I have been working on updating the locations in a new draft PR #172 |
…172) close #171 The tests for transcript segment elements are kind of confusing IMO. `transcript_segments` test fixture in `test_models` leverages `sequence_locations`. Some of these sequence locations have both start/end, but we only use start or end. I didn't change these because I don't think the values are actually tested. We can revisit in the future.
Feature description
We're altering when/how to set the start/end values of
SequenceLocation
objects in transcript segment elements of fusions, rather than setting both start and end every time. Now, start and end should be selectively used based on orientation and position in a fusion. More details are in respective working docs/written on the board next to Jeremy's desk.Use case
n/a
Proposed solution
No response
Alternatives considered
No response
Implementation details
No response
Potential Impact
No response
Additional context
No response
Contribution
None
The text was updated successfully, but these errors were encountered: