feat!: update to vrs 2.0 models #166
Conversation
| id: CURIE | None = Field(None, alias="_id") | ||
| label: StrictStr | None = None | ||
| sequence_location: LocationDescriptor | None = None | ||
|
|
||
| _get_id_val = field_validator("id")(return_value) |
There was a problem hiding this comment.
wanted to draw attention to these - it looks like everywhere return_value was used was verifying a CURIE. This is no longer needed. (And note to myself: I will make sure this is tested and works properly with the usage of CURIE from gene normalizer schema)
|
I'll review this tomorrow morning |
| "type": "SequenceReference" | ||
| }, | ||
| "start": 23253980, | ||
| "end": 23253981 |
There was a problem hiding this comment.
I agree–did this get addressed?
|
Just a note that, even though (I assume) we’re splitting out the changes to the genomic sequence start/end fields to use VRS 2.0 sequence locations in #171, that the genomic locations of |
yeah, I think we're conceiving of this as an existing error that is orthogonal to the aim of this PR, and a follow-up that overhauls how we're setting location starts/ends will address it exhaustively in #171 |
katiestahl
dismissed
ahwagner’s stale review
addressing SequenceLocation start/end in issue #171
…casing as the fusion classes)
…n (same casing as the fusion classes)" This reverts commit 2880e18.
|
This PR is stale because it has been open 1 day(s) with no activity. Please review this PR. |
close #95