-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: update to vrs 2.0 models #166
Merged
Merged
Changes from 88 commits
Commits
Show all changes
89 commits
Select commit
Hold shift + click to select a range
442083c
build!: remove vrsatile
katiestahl 4a538bb
wip: remove gene descriptor
katiestahl c0e8626
wip: remove gene descriptor
katiestahl 24e1a4c
progress updating models and adding back gene element wrapper
katiestahl 3e52ff2
adding back gene element
katiestahl 12ee931
Revert "progress updating models and adding back gene element wrapper"
katiestahl 6120473
Revert "adding back gene element"
katiestahl 6573780
converting descriptors
katiestahl 44e0574
remove todo
katiestahl 7796732
wip: adding back GeneElement wrapper, updating to camelCase, removing…
katiestahl c67d588
updating models
katiestahl 6ad8e33
fix: gene element type
katiestahl c1e8fad
wip: update constructors with updated param names from models
katiestahl 42d1224
Merge branch 'main' into issue-95-take2
katiestahl 7eabc25
update constructors from model changes
katiestahl 6cd7cfa
Merge branch 'issue-95-take2' of https://github.com/cancervariants/fu…
katiestahl 1e18144
minor fixes
katiestahl 76ef031
fix: updating variable casing
katiestahl 6f740e9
updating docstring
katiestahl c928b35
fix: variable casing and error messages
katiestahl a2d2e10
revert featureId back to string
katiestahl fe85297
Update src/fusor/models.py
katiestahl eb9da54
Update pyproject.toml
katiestahl bbae4bc
Update pyproject.toml
katiestahl 7634327
Update src/fusor/models.py
katiestahl a593c3b
fixes from pr comments
katiestahl 1c3959b
fixes from pr comments
katiestahl c8c90a7
Merge branch 'issue-95-take2' of https://github.com/cancervariants/fu…
katiestahl 838e2a2
wip: updating test examples with new models
katiestahl f5f5689
adding back unreachable else because ruff will complain otherwise
katiestahl c3136ce
fix: update example models with placeholders for sequence location an…
katiestahl 686b000
fix: casing for data to/from cool-seq-tool
katiestahl 1ce7f23
Update src/fusor/fusor.py
katiestahl 485035c
Update src/fusor/fusor.py
katiestahl 9f1ee60
fix: minimal gene response when creating gene
katiestahl 5bbc77c
fix: naming
katiestahl 5a8bea2
Update src/fusor/models.py
katiestahl ca97171
Update src/fusor/models.py
katiestahl 92fe98f
Update src/fusor/models.py
katiestahl 43f347f
Update src/fusor/models.py
katiestahl dba14ca
Update src/fusor/fusor.py
katiestahl a3e67d1
Update src/fusor/models.py
katiestahl 74db34c
updating constructor for SequenceLocation and adding SequenceReference
katiestahl 9cd280c
Merge branch 'issue-95-take2' of https://github.com/cancervariants/fu…
katiestahl cce6159
removing comment
katiestahl 58b0899
wip: start updates to nomenclature using new models
katiestahl 634ad7f
wip: progress on sequence location constructor
katiestahl 7334ac8
fix: tests and add sequence location id
katiestahl 9d08adf
wip: update test examples
katiestahl fc649b5
removing incorrect test cases- adding placeholders for now
katiestahl 1e0c7df
fix constructing sequence location
katiestahl 33e932b
fix: casing for sequencelocation
katiestahl 091e23a
updating sequence locations examples
katiestahl 1fbee7c
updating tests
katiestahl c873d6a
updating tests and adding option to getch gene id from alternate field
katiestahl ac72ecd
fix: json schema examples
katiestahl 3a9c20a
wip: updating fusor tests
katiestahl ab3de62
update nomenclature to use new models
katiestahl 6bf5f01
remove completed todo
katiestahl b952c9c
wip: updating fusor tests
katiestahl 16def6b
Update locations for mane transcript segment fixture/tests
jarbesfeld a624de5
wip: update tests with new models
katiestahl 620dc1a
Merge branch 'issue-95-take2' of https://github.com/cancervariants/fu…
katiestahl 6a6211b
update tests and examples with new models
katiestahl 3fd9615
update tests and examples with new models
katiestahl 9af8c72
update tests and examples with new models
katiestahl 871c3d9
update tests and examples with new models
katiestahl 01ef722
refactor: moving around logic to make more readable
katiestahl b811599
model updates
katiestahl 812a21b
Merge branch 'main' into issue-95-take2
katiestahl 9c083b9
model updates
katiestahl db4d6cb
updating models and tests
katiestahl 6c3b663
fix name
katiestahl c78ee2a
pin gene normalizer version where CURIE is still defined
katiestahl fb05793
updating json schema examples for models, removing labael from sequen…
katiestahl 2572534
remove sequencelocation label
katiestahl 62745b8
fix ruff errors
katiestahl 8732135
pinning pydantic version to stop validation error in tests
katiestahl acab073
test: updating test to fail with unexpected sequence id provided
katiestahl a0a4529
Update test fixtures for correct use of start and end"
jarbesfeld f1b82a0
update comment
katiestahl e9a70b1
Revert "Update test fixtures for correct use of start and end""
katiestahl dd3f7c1
Update src/fusor/models.py
katiestahl 774f559
Update src/fusor/fusor.py
katiestahl 8fd8d3f
Update src/fusor/fusor.py
katiestahl c664b77
fix: example data
katiestahl f00ddb2
Merge branch 'issue-95-take2' of https://github.com/cancervariants/fu…
katiestahl 2880e18
update fusion constructor to accept the body of a valid fusion (same …
katiestahl b9bff00
Revert "update fusion constructor to accept the body of a valid fusio…
katiestahl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,111 +1,93 @@ | ||
{ | ||
"type": "CategoricalFusion", | ||
"structural_elements": [ | ||
"structure": [ | ||
{ | ||
"type": "TranscriptSegmentElement", | ||
"transcript": "refseq:NM_004327.3", | ||
"gene_descriptor": { | ||
"type": "GeneDescriptor", | ||
"id": "normalize.gene:BCR", | ||
"gene_id": "hgnc:1014", | ||
"gene": { | ||
"type": "Gene", | ||
"id": "hgnc:1014", | ||
"label": "BCR" | ||
}, | ||
"element_genomic_end": { | ||
"id": "fusor.location_descriptor:NC_000022.11", | ||
"type": "LocationDescriptor", | ||
"label": "NC_000022.11", | ||
"location": { | ||
"type": "SequenceLocation", | ||
"sequence_id": "refseq:NC_000022.11", | ||
"interval": { | ||
"type": "SequenceInterval", | ||
"start": { | ||
"type": "Number", | ||
"value": 23253980 | ||
}, | ||
"end": { | ||
"type": "Number", | ||
"value": 23253981 | ||
} | ||
} | ||
} | ||
"elementGenomicEnd": { | ||
"id": "ga4gh:SL.5f5OVC3zReewA4S78X1eO0oJwWNbGYsY", | ||
"type": "SequenceLocation", | ||
"description": null, | ||
"xrefs": null, | ||
"alternativeLabels": null, | ||
"extensions": null, | ||
"sequenceReference": { | ||
"id": "refseq:NC_000022.11", | ||
"refgetAccession": "SQ.7B7SHsmchAR0dFcDCuSFjJAo7tX87krQ", | ||
"type": "SequenceReference" | ||
}, | ||
"start": 23253980, | ||
"end": 23253981 | ||
}, | ||
"exon_end": 2, | ||
"exon_end_offset": 182 | ||
"exonEnd": 2, | ||
"exonEndOffset": 182 | ||
}, | ||
{ | ||
"type": "LinkerSequenceElement", | ||
"linker_sequence": { | ||
"linkerSequence": { | ||
"id": "sequence:ACTAAAGCG", | ||
"type": "SequenceDescriptor", | ||
"sequence": "ACTAAAGCG", | ||
"residue_type": "SO:0000348" | ||
"type": "LiteralSequenceExpression", | ||
"sequence": "ACTAAAGCG" | ||
} | ||
}, | ||
{ | ||
"type": "TranscriptSegmentElement", | ||
"transcript": "refseq:NM_005157.5", | ||
"exon_start": 2, | ||
"exon_start_offset": -173, | ||
"gene_descriptor": { | ||
"id": "normalize.gene:ABL1", | ||
"type": "GeneDescriptor", | ||
"exonStart": 2, | ||
"exonStartOffset": -173, | ||
"gene": { | ||
"type": "Gene", | ||
"label": "ABL1", | ||
"gene_id": "hgnc:76" | ||
"id": "hgnc:76" | ||
}, | ||
"element_genomic_start": { | ||
"id": "fusor.location_descriptor:NC_000009.12", | ||
"type": "LocationDescriptor", | ||
"label": "NC_000009.12", | ||
"location": { | ||
"type": "SequenceLocation", | ||
"sequence_id": "refseq:NC_000009.12", | ||
"interval": { | ||
"type": "SequenceInterval", | ||
"start": { | ||
"type": "Number", | ||
"value": 130854064 | ||
}, | ||
"end": { | ||
"type": "Number", | ||
"value": 130854065 | ||
} | ||
} | ||
} | ||
"elementGenomicStart": { | ||
"id": "ga4gh:SL.tZYgaEJP2-d4Guv-n5gyhqOc07qH9xr6", | ||
"description": null, | ||
"xrefs": null, | ||
"alternativeLabels": null, | ||
"extensions": null, | ||
"type": "SequenceLocation", | ||
"sequenceReference": { | ||
"id": "refseq:NC_000009.12", | ||
"refgetAccession": "SQ.KEO-4XBcm1cxeo_DIQ8_ofqGUkp4iZhI", | ||
"type": "SequenceReference" | ||
}, | ||
"start": 130854064, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this should just be |
||
"end": 130854065 | ||
} | ||
} | ||
], | ||
"reading_frame_preserved": true, | ||
"critical_functional_domains": [ | ||
"readingFramePreserved": true, | ||
"criticalFunctionalDomains": [ | ||
{ | ||
"type": "FunctionalDomain", | ||
"status": "preserved", | ||
"associated_gene": { | ||
"id": "normalize.gene:hgnc%3A76", | ||
"type": "GeneDescriptor", | ||
"associatedGene": { | ||
"type": "Gene", | ||
"label": "ABL1", | ||
"gene_id": "hgnc:76" | ||
"id": "hgnc:76" | ||
}, | ||
"_id": "interpro:IPR000980", | ||
"id": "interpro:IPR000980", | ||
"label": "SH2 domain", | ||
"sequence_location": { | ||
"id": "fusor.location_descriptor:NP_005148.2", | ||
"type": "LocationDescriptor", | ||
"location": { | ||
"type": "SequenceLocation", | ||
"sequence_id": "refseq:NP_005148.2", | ||
"interval": { | ||
"type": "SequenceInterval", | ||
"start": { | ||
"type": "Number", | ||
"value": 127 | ||
}, | ||
"end": { | ||
"type": "Number", | ||
"value": 202 | ||
} | ||
} | ||
} | ||
"sequenceLocation": { | ||
"id": "ga4gh:SL.VQe2sf2aYArPcvjygq38JvFxRuDniE15", | ||
"description": null, | ||
"xrefs": null, | ||
"alternativeLabels": null, | ||
"extensions": null, | ||
"type": "SequenceLocation", | ||
"sequenceReference": { | ||
"id": "refseq:NP_005148.2", | ||
"refgetAccession": "SQ.dmFigTG-0fY6I54swb7PoDuxCeT6O3Wg", | ||
"type": "SequenceReference" | ||
}, | ||
"start": 127, | ||
"end": 202 | ||
} | ||
} | ||
] | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should just be
"end": 23253980
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree–did this get addressed?