Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build!: require python >=3.11 #200

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build!: require python >=3.11 #200

wants to merge 1 commit into from

Conversation

jsstevenson
Copy link
Member

@jsstevenson jsstevenson added the priority:low Low priority label Nov 13, 2024
korikuzma
korikuzma reviewed Nov 13, 2024
View reviewed changes
Copy link
Member

@korikuzma korikuzma left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to hold off until we can confirm that the dependencies work on 3.13 (not sure if you've already checked this)

update: Realized even without this change we technically do support 3.13. So separate thought to do here and in template would be >=3.11,<3.14 or can do <3.13 if we’re not ready to bump.

@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 7 day(s) with no activity. Please review this PR.

@github-actions github-actions bot added the stale label Nov 21, 2024
@korikuzma korikuzma removed the stale label Nov 21, 2024
@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 7 day(s) with no activity. Please review this PR.

@github-actions github-actions bot added the stale label Nov 29, 2024
@korikuzma korikuzma removed the stale label Nov 29, 2024
@jsstevenson
Copy link
Member Author

update: Realized even without this change we technically do support 3.13. So separate thought to do here and in template would be >=3.11,<3.14 or can do <3.13 if we’re not ready to bump.

personally I'm less concerned about people trying to front-run us, but maybe just for philosophical reasons. If you want to make an issue in the template repo maybe we can make a decision for everything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korikuzma korikuzma korikuzma left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
priority:low Low priority stale-exempt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsstevenson @korikuzma