Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update CST version and pin ga4gh.vrs version #216

Merged
merged 4 commits into from
Jan 9, 2025
Merged

build: update CST version and pin ga4gh.vrs version #216

merged 4 commits into from
Jan 9, 2025

Conversation

jarbesfeld
Copy link
Contributor

No description provided.

@jarbesfeld jarbesfeld added enhancement New feature or request priority:high High priority labels Jan 8, 2025
@jarbesfeld jarbesfeld requested a review from korikuzma January 8, 2025 17:59
@jarbesfeld jarbesfeld self-assigned this Jan 8, 2025
korikuzma
korikuzma requested changes Jan 8, 2025
View reviewed changes
Copy link
Member

@korikuzma korikuzma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I think you'll also want to pin the ga4gh.vrs version, since it's installing 2.0.0a13 (which has breaking changes)

@jsstevenson
Copy link
Member

jsstevenson commented Jan 8, 2025 •
edited
Loading

I think the failing test relates to a recurring issue we've seen with using a relaxed pin ~= for VRS-Python dependency declaration. It doesn't have anything to do with this PR IMO but should be addressed, separately or otherwise.

ope Kori got it first

@jarbesfeld jarbesfeld requested a review from korikuzma January 8, 2025 19:07
korikuzma
korikuzma requested changes Jan 9, 2025
View reviewed changes
Copy link
Member

@korikuzma korikuzma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • PR title should be updated to include ga4gh.vrs version pin too
  • You also need to update translator tests since get_nearest_transcript_junction kwarg was removed.

@jarbesfeld jarbesfeld changed the title build: update CST version build: update CST version and pin ga4gh.vrs version Jan 9, 2025
@jarbesfeld jarbesfeld requested a review from korikuzma January 9, 2025 14:36
@jarbesfeld jarbesfeld merged commit 69c1654 into main Jan 9, 2025
10 checks passed
@jarbesfeld jarbesfeld deleted the update_cst_version branch January 9, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korikuzma korikuzma korikuzma approved these changes

@jsstevenson jsstevenson jsstevenson approved these changes

Assignees

@jarbesfeld jarbesfeld

Labels
enhancement New feature or request priority:high High priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jarbesfeld @jsstevenson @korikuzma