refactor!: update cli #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korikuzma
added
priority:medium
Closed
|
@jsstevenson I am going to re-run the CDMs using prod env and update the s3 bucket with those |
jsstevenson
requested changes
Apr 3, 2024
Co-authored-by: James Stevenson <[email protected]>
Co-authored-by: James Stevenson <[email protected]>
Co-authored-by: James Stevenson <[email protected]>
Co-authored-by: James Stevenson <[email protected]>
|
@jsstevenson I can re-order once you're good with final changes. Just want to make the review easier |
jsstevenson
requested changes
Apr 3, 2024
|
@jsstevenson my bad. I thought you accepted this PR but it was the other MetaKB PR |
Co-authored-by: James Stevenson <[email protected]>
|
ope this is my fault |
korikuzma
commented
Apr 3, 2024
jsstevenson
approved these changes
Apr 3, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #244 . I tried not to make too many changes. I do think we should split up commands in a separate issue. This PR was just focused on updating the CLI for normalizer updates
Changes:
--load_normalizers_db. I think this should be an option in the normalizer themselves, similar to--update_alland--udpate_merged. I removed it in the CLI because it would instantiate the normalizer ddb twiceCLIRunning locally on mac intel (I added all files to s3 bucket):