-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: use cat-vrs-python + va-spec-python #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korikuzma
added
enhancement
New feature or request
priority:medium
Medium priority
labels
Nov 14, 2024
Going to take another look at this in the morning to see if I missed anything. Afterwards, I'll request your review @mcannon068nw |
This was
linked to
issues
Nov 14, 2024
mcannon068nw
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, no major concerns
This was referenced Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #388 , #395, #309
ga4gh.cat_vrs
+ga4gh.va_spec
packagesmetakb/schemas/annotation.py
,metakb/schemas/categorical_variation.py
, andmetakb/schemas/variation_statement.py
. (use cat-vrs-python and va-spec-python #388)ga4gh.vrs
version bumpedvariant.definingContext.expressions
tovariant.members
#309)extension.name
will always bevicc_normalizer_data
and value will containid
,label
, and optionalmondo_id
(for disease)CDMs can be found here:
s3://vicc-metakb/cdm-sandbox/20241114/
Note: I started doing study --> study statement / statement, but with an already large PR I decided to break this out. Will create new PR with this change.