Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: use cat-vrs-python + va-spec-python #404

Merged
merged 12 commits into from
Nov 20, 2024
Merged

feat!: use cat-vrs-python + va-spec-python #404

merged 12 commits into from
Nov 20, 2024

Conversation

korikuzma
Copy link
Member

@korikuzma korikuzma commented Nov 14, 2024

close #388 , #395, #309

  • Breaking changes
    • Update/add ga4gh packages
    • Standardize representing normalizer data in extensions
      • The extension.name will always be vicc_normalizer_data and value will contain id, label, and optional mondo_id (for disease)
  • Simplify assertion checks in tests

CDMs can be found here: s3://vicc-metakb/cdm-sandbox/20241114/

Note: I started doing study --> study statement / statement, but with an already large PR I decided to break this out. Will create new PR with this change.

@korikuzma korikuzma added enhancement New feature or request priority:medium Medium priority labels Nov 14, 2024
@korikuzma korikuzma self-assigned this Nov 14, 2024
@korikuzma
Copy link
Member Author

Going to take another look at this in the morning to see if I missed anything. Afterwards, I'll request your review @mcannon068nw

Copy link

@mcannon068nw mcannon068nw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, no major concerns

@korikuzma korikuzma merged commit 261c065 into staging Nov 20, 2024
14 checks passed
@korikuzma korikuzma deleted the issue-388 branch November 20, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:medium Medium priority
Projects
None yet
2 participants