Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add support for moa prognostic assertions #411

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Conversation

korikuzma
Copy link
Member

close #408

Note: This work revealed a bug with uniqueness constraints (#409). This will be addressed in a separate PR. This PR focuses on changes to the harvester + transformer: python3 -m pytest tests/unit/harvesters tests/unit/transformers

  • Harvester output changed
    • Therapy fields are now nested inside therapy key
    • Remove clinical_significance and retain original values from MOA
    • source_ids -> source_id since we only store one ID
  • MoaTransformer now supports MOA prognostic assertions

@korikuzma korikuzma added enhancement New feature or request priority:medium Medium priority labels Dec 13, 2024
@korikuzma korikuzma requested a review from katiestahl December 13, 2024 15:40
@korikuzma korikuzma self-assigned this Dec 13, 2024
Copy link

@katiestahl katiestahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@korikuzma korikuzma merged commit 7d72c99 into staging Dec 18, 2024
16 checks passed
@korikuzma korikuzma deleted the issue-408 branch December 18, 2024 15:08
@jsstevenson jsstevenson mentioned this pull request Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:medium Medium priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants