Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not upload profile from DNF, when it is disabled in conf #3496

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

jirihnidek
Copy link
Contributor

@jirihnidek jirihnidek commented Jan 15, 2025

  • Card ID: CCT-505
  • When rhsm.report_package_profile is disabled in rhsm.conf and rhsm.package_profile_on_trans is enabled, then profile should not be uploaded, because the rhsm.report_package_profile has higher priority as it is described in man page of rhsm.conf

@jirihnidek jirihnidek force-pushed the jhnidek/fix_async_dnf_upload_profile_conf branch from b0c175b to 84c1ed8 Compare January 15, 2025 11:06
Copy link

github-actions bot commented Jan 15, 2025

Coverage

Coverage (computed on Fedora latest) •
FileStmtsMissCoverMissing
TOTAL17432445874% 
report-only-changed-files is enabled. No files were changed during this commit :)

Tests Skipped Failures Errors Time
2416 14 💤 0 ❌ 0 🔥 33.612s ⏱️

* Card ID: CCT-505
* When rhsm.report_package_profile is disabled in rhsm.conf and
  rhsm.package_profile_on_trans is enabled, then profile should
  not be uploaded, because the rhsm.report_package_profile has
  higher priority as it is described in man page of rhsm.conf
@ptoscano ptoscano force-pushed the jhnidek/fix_async_dnf_upload_profile_conf branch from 84c1ed8 to 29e68c4 Compare January 15, 2025 16:20
Copy link
Contributor

@ptoscano ptoscano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@ptoscano
Copy link
Contributor

Passed QE verification, merging.

@ptoscano ptoscano merged commit 4540efb into main Jan 16, 2025
19 of 22 checks passed
@ptoscano ptoscano deleted the jhnidek/fix_async_dnf_upload_profile_conf branch January 16, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants