Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop usermode and pam_console usage/leftovers #3497

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

ptoscano
Copy link
Contributor

  1. pam_console was dropped in Fedora 39: https://fedoraproject.org/wiki/Changes/RemovePamConsole
  2. /usr/bin and /usr/sbin will be unified in Fedora 42: https://fedoraproject.org/wiki/Changes/Unify_bin_and_sbin

(1) means that there are useless files shipped, and (2) that it will not be possible to use usermode anymore. usermode never got a lot of usage, and sudo is a better replacement for it.

Card ID: CCT-1106
Card ID: CCT-990

Copy link

github-actions bot commented Jan 15, 2025

Coverage

Coverage (computed on Fedora latest) •
FileStmtsMissCoverMissing
TOTAL17432446174% 
report-only-changed-files is enabled. No files were changed during this commit :)

Tests Skipped Failures Errors Time
2416 14 💤 0 ❌ 0 🔥 33.005s ⏱️

@ptoscano
Copy link
Contributor Author

Hm something does not seem right in the Fedora Rawhide build, as it still tries to look for /usr/bin/subscription-manager. Moving back to draft for now.

@ptoscano ptoscano marked this pull request as draft January 15, 2025 15:35
@keszybz
Copy link

keszybz commented Jan 16, 2025

https://src.fedoraproject.org/rpms/subscription-manager/pull-request/55 has this plus some additional changes and it builds fine.

@ptoscano
Copy link
Contributor Author

https://src.fedoraproject.org/rpms/subscription-manager/pull-request/55 has this plus some additional changes and it builds fine.

The changes there are too "newer Fedora" dependent, and this packaging has to work with EL 10 too. I'll get this reviewed (it'll still fail), and add extra bits for the sbin+bin unification.

Fedora is working on unifying /usr/bin and /usr/sbin:
https://fedoraproject.org/wiki/Changes/Unify_bin_and_sbin
Because of that, we cannot ship anymore /usr/bin/subscription-manager
and /usr/sbin/subscription-manager as different executables.

/usr/bin/subscription-manager is actually provided for usage with
usermode, so non-root users invoking "subscription-manager" are prompted
for the root password. Nowadays most administrators use "sudo" for
running commands, and usermode did not get a lot of adoption.

Hence, simply drop the usage of consolehelper altogether. This makes
subscription-manager compatible with Fedora 42+, and in general drops a
very low used feature.

Card ID: CCT-1106
pam_console was dropped in Fedora 39:
https://fedoraproject.org/wiki/Changes/RemovePamConsole

Since the files have no use anymore, drop them altogether.

Card ID: CCT-990
@ptoscano ptoscano force-pushed the ptoscano/usermode-pam_console-removals branch from d9e0ecc to 5e12976 Compare January 16, 2025 15:10
@ptoscano
Copy link
Contributor Author

I'm un-drafting this PR to get it merged, even if it does not build yet on Fedora Rawhide. There are more changes needed on Rawhide, and I want to not overload this.

@ptoscano ptoscano marked this pull request as ready for review January 16, 2025 15:11
@ptoscano
Copy link
Contributor Author

/packit build

Copy link
Contributor

@m-horky m-horky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@m-horky m-horky merged commit 1cbfc6b into main Jan 16, 2025
19 of 22 checks passed
@m-horky m-horky deleted the ptoscano/usermode-pam_console-removals branch January 16, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants