Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.29] Backport of support for content templates #3502

Conversation

rverdile
Copy link
Contributor

These are the features needed to support content templates

@rverdile rverdile force-pushed the cherry-pick-for-templates branch 6 times, most recently from 6dec86f to 1dc2859 Compare January 28, 2025 21:58
@rverdile rverdile changed the title Cherry pick for templates backport for templates support Jan 28, 2025
@rverdile rverdile marked this pull request as ready for review January 28, 2025 22:08
@jirihnidek
Copy link
Contributor

/packit build

Copy link

No config file for packit (e.g. .packit.yaml) found in candlepin/subscription-manager on commit 1dc2859

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

5 similar comments
Copy link

No config file for packit (e.g. .packit.yaml) found in candlepin/subscription-manager on commit 1dc2859

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

Copy link

No config file for packit (e.g. .packit.yaml) found in candlepin/subscription-manager on commit 1dc2859

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

Copy link

No config file for packit (e.g. .packit.yaml) found in candlepin/subscription-manager on commit 1dc2859

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

Copy link

No config file for packit (e.g. .packit.yaml) found in candlepin/subscription-manager on commit 1dc2859

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

Copy link

No config file for packit (e.g. .packit.yaml) found in candlepin/subscription-manager on commit 1dc2859

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

@jirihnidek jirihnidek self-assigned this Jan 29, 2025
@jirihnidek
Copy link
Contributor

@rverdile ... we do not have packit configuration file for this branch. Can you please review this PR: #3503

@ptoscano ptoscano changed the title backport for templates support [1.29] Backport of support for content templates Jan 31, 2025
rverdile and others added 2 commits January 31, 2025 15:43
* Card-ID: CCT-762
* Removes validation to prevent specifying environment during
  registration with activation key

(cherry picked from commit f222b57)
* Allow to register also with environment names. It is possible
  to use environment names with username & password and
  activation-keys & organization authentication
* It is not allowed to use `environmets` and `environment_names`
  registration options together, because it is not possible to use
  env. IDs and names together on candlepin server
* Introduce environment_type as another registration_option
  * When consumer object is returned and it contains environments,
    then all environments are checked if type of environment
    matches given environment_type. If type is missing or is
    different, then system is unregistered and exception is
    raised
* Modified few unit tests related to environments
* Added few unit tests

(cherry picked from commit 8140ecc)
@rverdile rverdile force-pushed the cherry-pick-for-templates branch from 1dc2859 to e7bdb17 Compare January 31, 2025 20:45
Copy link
Contributor

@jirihnidek jirihnidek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for backport.

@jirihnidek jirihnidek merged commit db4183f into candlepin:subscription-manager-1.29 Feb 3, 2025
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants