Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Try to convert ESX VM UUID after hw upgrade #415

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix: Try to convert ESX VM UUID after hw upgrade #415

wants to merge 2 commits into from
+37 −6

Conversation

jirihnidek
Copy link
Collaborator

  • Card ID: CCT-606
  • It is only draft ATM, because I cannot test it

@jirihnidek jirihnidek force-pushed the jhnidek/CCT-606 branch 2 times, most recently from ea1ddc5 to 02aa2bc Compare August 5, 2024 07:36
@jirihnidek
Copy link
Collaborator Author

/packit test

@jirihnidek
Copy link
Collaborator Author

/packit build

@jirihnidek jirihnidek mentioned this pull request Jan 15, 2025
Draft
@cnsnyder cnsnyder self-assigned this Jan 23, 2025
cnsnyder
cnsnyder reviewed Jan 23, 2025
View reviewed changes
Copy link
Member

@cnsnyder cnsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall, just a few questions to confirm before we proceed!

virtwho/virt/esx/esx.py Outdated Show resolved Hide resolved
virtwho/virt/esx/esx.py Show resolved Hide resolved
@jirihnidek
fix: Try to convert ESX VM UUID after hw upgrade
5fc31b5 
* Card ID: CCT-606
* It is only draft ATM, because I cannot test it
cnsnyder
cnsnyder reviewed Jan 23, 2025
View reviewed changes
Copy link
Member

@cnsnyder cnsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, going to try a scratch build prior to merging! I'll update with anything we learn from it.

@jirihnidek
fix: Try to different logic for smbiosVersion 2.7
a03290c 
* Card ID: CCT-606
* Added more debug prints
* Changed the logic a little bit. Do not convert the UUID
  from big-endian to little-endian, when
  acpi.smbiosVersion2.7: FALSE
* TODO: squash this and previous commit, when it will work
  as expected
@cnsnyder cnsnyder mentioned this pull request Jan 28, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnsnyder cnsnyder cnsnyder left review comments

Assignees

@cnsnyder cnsnyder

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jirihnidek @cnsnyder