Enable Ubuntu Pro in docker images #49
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build docker images with Ubuntu Pro to get relevant security fixes. If a non-commented "token:" line exists in the secret but the attachment fails, the build will error. However if no token exists it will not error and build without Ubuntu Pro. This is to ensure the GitHub action fails if the token becomes invalid but also allows for local development without a token. For local builds, the file pro-attach-config.yaml is used. Set a token to build with Ubuntu Pro. For GitHub actions, create a secret called PRO_ATTACH_CONFIG with the same contents as as pro-attach-config.yaml file. Closes: canonical#48
|
Before we merge this we need to add a new secret to the main repository called PRO_ATTACH_CONFIG with the following contents - replacing TOKEN with the internal staff token. |
|
Hi @lathiat ! Could you rebase this? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build docker images with Ubuntu Pro to get relevant security fixes.
If a non-commented "token:" line exists in the secret but the attachment
fails, the build will error. However if no token exists it will not
error and build without Ubuntu Pro. This is to ensure the GitHub action
fails if the token becomes invalid but also allows for local development
without a token.
For local builds, the file pro-attach-config.yaml is used. Set a token
to build with Ubuntu Pro.
For GitHub actions, create a secret called PRO_ATTACH_CONFIG with the
same contents as as pro-attach-config.yaml file.
Closes: #48