Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add 1.6 edge and beta bundle files #467

Merged
merged 6 commits into from
Aug 17, 2022
Merged

add 1.6 edge and beta bundle files #467

merged 6 commits into from
Aug 17, 2022

Conversation

DnPlas
Copy link
Contributor

@DnPlas DnPlas commented Jul 11, 2022 •
edited
Loading

Create edge and beta bundle files with upgraded components versions

NOTE: unchecked items are the ones whose version is still under discussion/missing, and thus it hasn't been updated in the bundles definition. Check the item ONLY after modifying the bundle files.

The following versions were extracted from kubeflow/manifests README.md and kubeflow/manifests#2242:

Useful links

@DnPlas DnPlas changed the title feat: add 1.6 edge bundle file RFC add 1.6 edge bundle files Jul 11, 2022
@DnPlas DnPlas force-pushed the dnplas-1.6-release branch 3 times, most recently from c4f512d to 46a3fc9 Compare July 11, 2022 21:45
@DnPlas DnPlas marked this pull request as ready for review July 11, 2022 21:46
@DnPlas DnPlas requested a review from a team as a code owner July 11, 2022 21:46
@ca-scribner
Copy link
Contributor

ca-scribner commented Jul 12, 2022 •
edited
Loading

Upstream kfp uses argo 3.2.3 (specifically, image gcr.io/ml-pipeline/argoexec:v3.2.3-license-compliance which I think they recompile for some reason that helps with license compliance?). I rendered the manifests to make sure it isn't overwritten somewhere else, but the final product uses version 3.2.3

edit: I made this change to the list above

@DnPlas DnPlas force-pushed the dnplas-1.6-release branch 2 times, most recently from 7176eda to 9deac22 Compare July 15, 2022 01:51
@ca-scribner
Copy link
Contributor

Upstream notebooks says they will be using istio 1.14 instead of 1.13 (see this comment)

natalian98
natalian98 reviewed Jul 20, 2022
View reviewed changes
releases/1.6/edge/kubeflow/bundle.yaml
_github_repo_name: istio-operators
istio-pilot:
charm: istio-pilot
channel: 1.11/edge
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tensorboard-controller will need a more recent version of istio-pilot, at least rev 76 due to the gateway relation. Can we promote latest/edge since it also includes some fixes?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that makes sense. @DnPlas any objections?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't our istio 1.11/edge tied to latest/edge in this case?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I think 1.11/edge really means "whatever we eventually put in 1.11/edge", since 1.11 is the version we're actively working on now. Not necessarily what is there now

@DnPlas DnPlas force-pushed the dnplas-1.6-release branch 3 times, most recently from 4c300b3 to 97fa609 Compare July 21, 2022 16:51
@ca-scribner
Copy link
Contributor

Upstream kfp uses argo 3.2.3 (specifically, image gcr.io/ml-pipeline/argoexec:v3.2.3-license-compliance which I think they recompile for some reason that helps with license compliance?). I rendered the manifests to make sure it isn't overwritten somewhere else, but the final product uses version 3.2.3

edit: I made this change to the list above

Ignore everything I said here. They pushed a new manifest after I said it, and the argo version is now 3.3.8

@ca-scribner
Copy link
Contributor

Should this bundle include knative?

ca-scribner
ca-scribner suggested changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@ca-scribner ca-scribner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't have time right now to make sure I did it correctly, but we want to remove envoy and mlmd from the bundle

@DnPlas DnPlas changed the title RFC add 1.6 edge bundle files add 1.6 edge and beta bundle files Aug 17, 2022
DomFleischmann
DomFleischmann approved these changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@DomFleischmann DomFleischmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DnPlas
Copy link
Contributor Author

DnPlas commented Aug 17, 2022

Didn't have time right now to make sure I did it correctly, but we want to remove envoy and mlmd from the bundle

yup, removed

@ca-scribner ca-scribner merged commit a25d479 into master Aug 17, 2022
@ca-scribner ca-scribner deleted the dnplas-1.6-release branch August 17, 2022 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natalian98 natalian98 natalian98 left review comments

@ca-scribner ca-scribner ca-scribner approved these changes

@DomFleischmann DomFleischmann DomFleischmann approved these changes

@agathanatasha agathanatasha agathanatasha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DnPlas @ca-scribner @agathanatasha @DomFleischmann @natalian98