feat: add uv plugin to charmcraft #2050
Conversation
bepri
force-pushed
the
work/uv-plugin-add/CRAFT-3816
branch
from
1c7b6f2 to
4f47635
Compare
lengau
force-pushed
the
work/uv-plugin-add/CRAFT-3816
branch
from
4f47635 to
8e38ee7
Compare
uv.lock
Outdated
There was a problem hiding this comment.
out of curiosity, why was this file updated? And how?
There was a problem hiding this comment.
Definitely from me running "uv sync" or "uv lock" at some point without telling it to freeze the lock file by mistake. @lengau would you like me to revert that or should we keep it in?
There was a problem hiding this comment.
I assume this was necessary to bump the version of craft-parts - I'm just wondering about the "correct" procedure here
There was a problem hiding this comment.
Yeah any time a dependency changes we should update the lock file. uv sync or uv lock should do the minimum changes needed to meet the new dependencies.
| service_factory.lifecycle.run("stage") | ||
|
|
||
| # Check that the part install directory looks correct. | ||
| assert (install_path / "src" / "charm.py").read_text() == "# Charm file" |
There was a problem hiding this comment.
I assume that this copying of the original source is a charmcraft thing?
There was a problem hiding this comment.
I believe so - I took this test directly from the existing poetry tests since the two are so similar.
There was a problem hiding this comment.
It is - the charm isn't necessarily an installable module and needs to be included in the src directory.
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Needs canonical/craft-parts#945
Closes #2040.
CRAFT-3816