Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(store): better error message with fetch-lib #2084

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(store): better error message with fetch-lib #2084

wants to merge 1 commit into from
+180 −403

Conversation

lengau
Copy link
Collaborator

@lengau lengau commented Jan 17, 2025

Fixes #1721
CRAFT-3352

@lengau lengau requested review from bepri and mr-cal January 17, 2025 01:18
@lengau lengau marked this pull request as ready for review January 17, 2025 01:31
@lengau
Copy link
Collaborator Author

lengau commented Jan 17, 2025

Spread test failure unrelated - an unrelated test simply reached the kill timeout.

bepri
bepri approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@bepri bepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muuuuuch cleaner. Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bepri bepri bepri approved these changes

@tigarmo tigarmo tigarmo approved these changes

@mr-cal mr-cal Awaiting requested review from mr-cal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fetch-lib error is useless/misleading
3 participants
@lengau @tigarmo @bepri