Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MISC] Fix build workflow #16

Merged
merged 4 commits into from
Nov 27, 2023
Merged

[MISC] Fix build workflow #16

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b6c43a8
Fix build workflow
dragomirp Nov 24, 2023
84a5638
Update base field
dragomirp Nov 24, 2023
9da66c8
Split base on at
dragomirp Nov 24, 2023
946573e
Remove autoupdate of rockcraft.yaml version
dragomirp Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ jobs:
run: |
app_version=$(yq '.version' rockcraft.yaml)
version=$(yq '(.version|split("-"))[0]' rockcraft.yaml)
base=$(yq '(.base|split(":"))[1]' rockcraft.yaml)
base=$(yq '(.base|split("@"))[1]' rockcraft.yaml)
tag=${version}-${base}_edge
sed -i "s/${app_version}/${tag}/g" rockcraft.yaml
sed -i "s/${app_version}/${base}/g" rockcraft.yaml
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Underscore no longer accepted. Do we really need to change the version on the fly?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re: Do we really need to change the version on the fly?

Otherwise how to set OCI factory compatible version/tag (8.0.33-22.04_edge)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise how to set OCI factory compatible version/tag (8.0.33-22.04_edge)?

The registry tag is set in the publish workflow here. I don't think we need to change the version in rockcraft.yaml at all with our current release pipeline.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure why it is here. BTW, MongoDB ROCK is not touching it: https://github.com/canonical/charmed-mongodb-rock/blob/5-22.04/.github/workflows/publish.yaml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following up on MM discussion, will remove the update to rockcraft.yaml and see how it goes.

rockcraft pack
- name: Upload locally built ROCK artifact
uses: actions/upload-artifact@v3
Expand Down
2 changes: 1 addition & 1 deletion rockcraft.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: charmed-postgresql # the name of your ROCK
base: ubuntu:22.04 # the base environment for this ROCK
base: ubuntu@22.04 # the base environment for this ROCK
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dots in deprecated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shayancanonical JFYI, re: MySQL ROCK.

version: '14.9' # just for humans. Semantic versioning is recommended
summary: PostgreSQL in a ROCK. # 79 char long summary
description: |
Expand Down