Superset ROCK for review #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+17
to
+25
| override: replace | ||
| summary: "superset-ui service" | ||
| startup: disabled | ||
| command: "/app/k8s/k8s-bootstrap.sh" | ||
| environment: | ||
| CHARM_FUNCTION: "app-gunicorn" | ||
| SUPERSET_SECRET_KEY: "supersetR0cks!" | ||
| ADMIN_PASSWORD: "admin" | ||
| SUPERSET_LOAD_EXAMPLES: True |
There was a problem hiding this comment.
Note that the on-success and on-failure actions are restart by default. See Pebble readme.
You might want to make that explicit in the rockcraft.yaml to avoid any surprises.
Comment on lines
+114
to
+132
| # Required dependencies missing from Superset requirements.txt | ||
| pip install Pillow==10.1.0 | ||
| pip install requests==2.31.0 | ||
| pip install jmespath==1.0.1 | ||
|
|
||
| # Optional dependencies for Database connectors | ||
| pip install psycopg2-binary==2.9.4 | ||
| pip install sqlalchemy==1.4.51 | ||
| pip install Werkzeug==2.3.7 | ||
| pip install Authlib==1.2.1 | ||
| pip install elasticsearch-dbapi==0.2.10 | ||
| pip install trino==0.327.0 | ||
| pip install pyhive==0.7.0 | ||
| pip install thrift==0.16.0 | ||
| pip install sqlalchemy-redshift==0.8.1 | ||
| pip install urllib3==1.26.11 | ||
|
|
||
| # Monitoring | ||
| pip install sentry-sdk==0.10.2 |
There was a problem hiding this comment.
nit: should you keep them in file(s)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for review of the Superset ROCK.