Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proviers/base: add requires for bluetooth4/beacon_eddystone_url_* (New) #1646

Merged
merged 3 commits into from
Feb 21, 2025

Conversation

hector-cao
Copy link
Contributor

@hector-cao hector-cao commented Dec 10, 2024

WARNING: This modifies com.canonical.certification::sru-server

Description

In order to pass, the test bluetooth4/beacon_eddystone_url_* needs:

  • bluez package/snap (+ adequate connections for ubuntu core)

This PR add requires section to the test bluetooth4/beacon_eddystone_url_*

Resolved issues

During Intel IOTG certification test run, we bumped into this test failure for server classic image,
It took us some time to realize that the bluez package is missing, this time spent can be saved with this
requires section

Documentation

N/A

Tests

The test runs successfully on 22.04 server image

@hector-cao hector-cao changed the title proviers/base: add requires for bluetooth4/beacon_eddystone_url_* proviers/base: add requires for bluetooth4/beacon_eddystone_url_* (New) Dec 10, 2024
Copy link
Collaborator

@pieqq pieqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thanks for this PR. I have a comment below.

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.30%. Comparing base (10e8b35) to head (13d7dae).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1646   +/-   ##
=======================================
  Coverage   49.30%   49.30%           
=======================================
  Files         373      373           
  Lines       40454    40454           
  Branches     6834     6834           
=======================================
  Hits        19946    19946           
  Misses      19783    19783           
  Partials      725      725           
Flag Coverage Δ
provider-base 25.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@zongminl zongminl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thank you.

Copy link
Collaborator

@pieqq pieqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thanks!

In order to pass, the test bluetooth4/beacon_eddystone_url_* needs:
- bluez package/snap (+ adequate connections for ubuntu core)
… bluez is not installed
@pieqq pieqq merged commit 77728a6 into canonical:main Feb 21, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants