Skip to content

Fixed eddystone_scanner fallback issue (New) #1967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

stanley31huang
Copy link
Collaborator

@stanley31huang stanley31huang commented Jun 19, 2025

fixed eddystone_scanner fallback issue

Description

In the beacontools/scanner.py, it will issue LE Advertising Scan Enable or LE Extended Advertising Scan Enable command based on the HCI Core version, so we should not have the fallback mechanisim in the eddystone_scanner.py script.

Resolved issues

Documentation

Tests

Sideloaded the checkbox-support modules on system running Ubuntu Desktop 18 with bluetooth 4.2 adapter

(checkbox-shell) root@OEM-QA:~# PYTHONPATH=checkbox-support/ python3 checkbox-support/checkbox_support/scripts/eddystone_scanner.py -D hci0
Issue LE Set Scan Parameters by hci command
Issue LE Set Scan Enable by hci command
Issue LE Set Scan Enable by hci command
Eddystone beacon detected: URL: https://www.ubuntu.com.com/ <mac: c2:c7:b7:7f:ca:33> <rssi: -53>

On an IoT platform running Ubuntu Server 24 with bluetooth 5.4

ubuntu@ubuntu:~$ sudo PYTHONPATH=checkbox-support/ python3 checkbox-support/checkbox_support/scripts/eddystone_scanner.py -D hci0
Issue LE Set Extended Scan Parameters by hci command
Issue LE Set Extended Scan Enable by hci command
Issue LE Set Extended Scan Enable by hci command
Eddystone beacon detected: URL: https://www.ubuntu.com.com/ <mac: c7:b7:7f:ca:33:01> <rssi: -65>

On an IoT platform running Ubuntu Server 24 with bluetooth 6.0 adapter

ubuntu@ubuntu:~$ sudo PYTHONPATH=checkbox-support/ python3 checkbox-support/checkbox_support/scripts/eddystone_scanner.py -D hci1
Issue LE Set Extended Scan Parameters by hci command
Issue LE Set Extended Scan Enable by hci command
Issue LE Set Extended Scan Enable by hci command
Eddystone beacon detected: URL: https://www.ubuntu.com.com/ <mac: c7:b7:7f:ca:33:01> <rssi: -71>

fixed eddystone_scanner fallback issue
@stanley31huang stanley31huang marked this pull request as draft June 19, 2025 02:58
revicsed scripts and unit tests
@stanley31huang stanley31huang changed the title Fixed eddystone_scanner fallback issue Fixed eddystone_scanner fallback issue (New) Jun 23, 2025
update unit tests
revised unit test
Copy link

codecov bot commented Jun 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.56%. Comparing base (ada9397) to head (8bdbb41).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1967   +/-   ##
=======================================
  Coverage   50.55%   50.56%           
=======================================
  Files         384      384           
  Lines       41116    41112    -4     
  Branches     7628     7530   -98     
=======================================
+ Hits        20786    20787    +1     
+ Misses      19586    19581    -5     
  Partials      744      744           
Flag Coverage Δ
checkbox-support 64.02% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

revised unit test
@stanley31huang stanley31huang force-pushed the revise_eddystone_scanner branch from ce8261a to 60716d7 Compare June 23, 2025 13:04
revised scripts and unit tests
revised unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant