Skip to content

Updated before-suspend jobs to include the "before" flag (bugfix) #1968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fernando79513
Copy link
Collaborator

@fernando79513 fernando79513 commented Jun 20, 2025

WARNING: This modifies com.canonical.certification::sru-server

Description

This PR introduces the "before" field for the resolution_before_suspend tests to ensure they are run before suspend.

Resolved issues

https://warthogs.atlassian.net/browse/CHECKBOX-1626

Documentation

Tests

The test has been run on some devices that were failing these tests before due to incorrect ordering:

@fernando79513 fernando79513 changed the title Updated before-suspend hobs to include the "before" flag Updated before-suspend hobs to include the "before" flag (bugfix= Jun 20, 2025
@fernando79513 fernando79513 changed the title Updated before-suspend hobs to include the "before" flag (bugfix= Updated before-suspend hobs to include the "before" flag (bugfix) Jun 20, 2025
Copy link

codecov bot commented Jun 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.60%. Comparing base (2305e2c) to head (be7c3fd).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1968   +/-   ##
=======================================
  Coverage   50.60%   50.60%           
=======================================
  Files         384      384           
  Lines       41180    41180           
  Branches     7642     7642           
=======================================
  Hits        20841    20841           
  Misses      19589    19589           
  Partials      750      750           
Flag Coverage Δ
provider-base 25.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fernando79513 fernando79513 changed the title Updated before-suspend hobs to include the "before" flag (bugfix) Updated before-suspend jobs to include the "before" flag (bugfix) Jun 23, 2025
Copy link
Collaborator

@Hook25 Hook25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants