Skip to content

Commit

Permalink
tests(pro): bump pycloudlib add noble release to pro tests (#5719)
Browse files Browse the repository at this point in the history
Since Noble is an LTS which supports Ubuntu Pro add integration
test coverage for that feature.

Bump pycloudlib dependency to 1!9.2 which allows cloud-init
integration tests to obtain service_account_email configuration from
the .config/pycloudlib.toml:

[gce]
credentials_path = <path>

without the need to also provide `service_account_email` in
pycloudlib.toml.
  • Loading branch information
blackboxsw committed Sep 21, 2024
1 parent b36ddb1 commit 067a464
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion integration-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# PyPI requirements for cloud-init integration testing
# https://cloudinit.readthedocs.io/en/latest/topics/integration_tests.html
#
pycloudlib>=1!6.7.0,<1!8
pycloudlib>=1!6.7.0,<1!9.3

# Avoid breaking change in `testpaths` treatment forced
# test/unittests/conftest.py to be loaded by our integration-tests tox env
Expand Down
3 changes: 2 additions & 1 deletion tests/integration_tests/modules/test_ubuntu_pro.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
FOCAL,
IS_UBUNTU,
JAMMY,
NOBLE,
)
from tests.integration_tests.util import (
get_feature_flag_value,
Expand Down Expand Up @@ -236,7 +237,7 @@ def maybe_install_cloud_init(session_cloud: IntegrationCloud):


@pytest.mark.skipif(
not all([IS_UBUNTU, CURRENT_RELEASE in [BIONIC, FOCAL, JAMMY]]),
CURRENT_RELEASE not in [BIONIC, FOCAL, JAMMY, NOBLE],
reason="Test runs on Ubuntu LTS releases only",
)
@pytest.mark.skipif(
Expand Down

0 comments on commit 067a464

Please sign in to comment.