Skip to content

Commit

Permalink
test(hotplug): reenable vpc test in focal (#5492)
Browse files Browse the repository at this point in the history
After the fix for LP: 2055397 is released, we can re-enable this tests.

Add additional assertions to verify that every route has metrics
configured.
  • Loading branch information
aciba90 committed Sep 18, 2024
1 parent df75b52 commit c62d7f2
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion tests/integration_tests/modules/test_hotplug.py
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,6 @@ def test_multi_nic_hotplug(setup_image, session_cloud: IntegrationCloud):
verify_clean_boot(client)


@pytest.mark.skipif(CURRENT_RELEASE <= FOCAL, reason="See LP: #2055397")
@pytest.mark.skipif(PLATFORM != "ec2", reason="test is ec2 specific")
@pytest.mark.skip(reason="IMDS race, see GH-5373. Unskip when fixed.")
def test_multi_nic_hotplug_vpc(setup_image, session_cloud: IntegrationCloud):
Expand Down Expand Up @@ -353,6 +352,12 @@ def test_multi_nic_hotplug_vpc(setup_image, session_cloud: IntegrationCloud):
r = bastion.execute(f"ping -c1 {secondary_priv_ip6}")
assert r.ok, r.stdout

# Check every route has metrics associated. See LP: #2055397
ip_route_show = client.execute("ip route show")
assert ip_route_show.ok, ip_route_show.stderr
for route in ip_route_show.splitlines():
assert "metric" in route, "Expected metric to be in the route"

# Remove new NIC
client.instance.remove_network_interface(secondary_priv_ip4)
_wait_till_hotplug_complete(client, expected_runs=2)
Expand Down

0 comments on commit c62d7f2

Please sign in to comment.