fix(net): Make duplicate route add succeed. (#5343)

This behaves the same but doesn't fail when adding an existing route. Fixes GH-3441 Fixes GH-3595
canonical · May 29, 2024 · e432a31 · e432a31
1 parent 00ab328
commit e432a31
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/cloudinit/net/netops/iproute2.py b/cloudinit/net/netops/iproute2.py
@@ -50,7 +50,7 @@ def add_route(
                 "ip",
                 "-4",
                 "route",
-                "add",
+                "replace",
                 route,
                 *gateway_args,
                 "dev",

diff --git a/tests/unittests/net/test_init.py b/tests/unittests/net/test_init.py
@@ -1031,7 +1031,7 @@ def test_ephemeral_ipv4_network_with_new_default_route(self, m_subp):
                     "ip",
                     "-4",
                     "route",
-                    "add",
+                    "replace",
                     "192.168.2.1",
                     "dev",
                     "eth0",
@@ -1044,7 +1044,7 @@ def test_ephemeral_ipv4_network_with_new_default_route(self, m_subp):
                     "ip",
                     "-4",
                     "route",
-                    "add",
+                    "replace",
                     "default",
                     "via",
                     "192.168.2.1",