-
Notifications
You must be signed in to change notification settings - Fork 882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add alpine unittests to ci #5121
Conversation
15a21e6
to
c44fc43
Compare
74a0bee
to
b4d74ee
Compare
Cloud-init has Alpine Linux support, yet does not regularly test it. Alpine is an attractive addition to the test matrix since it is easily available to run in lxc, and it has several alternative components to test against: - busybox: non-GNU posix-compliant tools - musl: libc alternative to glibc - openrc: init system alternative to systemd
b4d74ee
to
f50807b
Compare
Looks like the job failed: |
It succeeded a few weeks back but after a rebase to fix a conflict this test started failing and I haven't taken the time to debug it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding support for unit tests on other platforms than Ubuntu!
Instead of using incus
, introducing a new tool, what about using the new image server for lxd[1]?
We could add the image server by lxc remote add images https://images.lxd.canonical.com --protocol=simplestreams
or switch the lxd snap channel to 5.21/stable
, which contains the image server by default.
[1] https://discourse.ubuntu.com/t/new-lxd-image-server-available-images-lxd-canonical-com/43824
When I proposed this PR, that image server was not yet available to use, but I suppose managing one tool would be simpler than two. I can update it. |
If we're doing LXD (and since the job is still failing), https://github.com/canonical/setup-lxd could be an option too. |
5e0b844
to
0dcb89f
Compare
0dcb89f
to
63a1186
Compare
@aciba90 @TheRealFalcon I have it working with the lxd Github Actions. Ready for re-review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Proposed Commit Message
Additional Context
Blocked by #5119 and #5120. Once those land, unittests will pass on Alpine.Both have landed, ready for review.
Merge type