Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alpine unittests to ci #5121

Merged
merged 3 commits into from
Apr 25, 2024
Merged

Conversation

holmanb
Copy link
Member

@holmanb holmanb commented Mar 30, 2024

Proposed Commit Message

test: Add alpine to ci

Cloud-init has Alpine Linux support, yet does not regularly test it.

Alpine is an attractive addition to the test matrix since it is easily
available to run in lxc, and it has several alternative components to test
against:

- busybox: non-GNU posix-compliant tools
- musl: libc alternative to glibc
- openrc: init system alternative to systemd

Additional Context

Blocked by #5119 and #5120. Once those land, unittests will pass on Alpine.

Both have landed, ready for review.

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

@holmanb holmanb force-pushed the holmanb/alpine-ci branch 19 times, most recently from 15a21e6 to c44fc43 Compare April 1, 2024 16:33
@holmanb holmanb changed the title Holmanb/alpine ci Add alpine unittests to ci Apr 1, 2024
@holmanb holmanb mentioned this pull request Apr 2, 2024
2 tasks
Cloud-init has Alpine Linux support, yet does not regularly test it.

Alpine is an attractive addition to the test matrix since it is easily
available to run in lxc, and it has several alternative components to test
against:

- busybox: non-GNU posix-compliant tools
- musl: libc alternative to glibc
- openrc: init system alternative to systemd
@TheRealFalcon
Copy link
Member

@holmanb
Copy link
Member Author

holmanb commented Apr 21, 2024

Looks like the job failed:
https://github.com/canonical/cloud-init/actions/runs/8668134702/job/23775704648?pr=5121

It succeeded a few weeks back but after a rebase to fix a conflict this test started failing and I haven't taken the time to debug it.

Copy link
Contributor

@aciba90 aciba90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding support for unit tests on other platforms than Ubuntu!

Instead of using incus, introducing a new tool, what about using the new image server for lxd[1]?

We could add the image server by lxc remote add images https://images.lxd.canonical.com --protocol=simplestreams or switch the lxd snap channel to 5.21/stable, which contains the image server by default.

[1] https://discourse.ubuntu.com/t/new-lxd-image-server-available-images-lxd-canonical-com/43824

.github/workflows/alpine-unittests.yml Outdated Show resolved Hide resolved
@holmanb
Copy link
Member Author

holmanb commented Apr 24, 2024

Instead of using incus, introducing a new tool, what about using the new image server for lxd[1]?

We could add the image server by lxc remote add images https://images.lxd.canonical.com --protocol=simplestreams or switch the lxd snap channel to 5.21/stable, which contains the image server by default.

When I proposed this PR, that image server was not yet available to use, but I suppose managing one tool would be simpler than two. I can update it.

@TheRealFalcon
Copy link
Member

If we're doing LXD (and since the job is still failing), https://github.com/canonical/setup-lxd could be an option too.

@holmanb holmanb force-pushed the holmanb/alpine-ci branch 2 times, most recently from 5e0b844 to 0dcb89f Compare April 24, 2024 23:59
@holmanb
Copy link
Member Author

holmanb commented Apr 25, 2024

@aciba90 @TheRealFalcon I have it working with the lxd Github Actions. Ready for re-review!

Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@holmanb holmanb merged commit 641b107 into canonical:main Apr 25, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants