Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(freebsd): support freebsd find part by gptid and ufsid #5122

Merged
merged 2 commits into from
Apr 8, 2024
Merged

feat(freebsd): support freebsd find part by gptid and ufsid #5122

merged 2 commits into from
Apr 8, 2024

Conversation

jinkkkang
Copy link
Contributor

Proposed Commit Message

feat(freebsd): support freebsd find part by gptid and ufsid

freebsd obtained device partition name by the function find_freebsd_part, the params of function is the device name mounted,  usually is first  field of /etc/fstab ,  like /dev/gpt/rootfs,  but freebsd fstab also support gptid or ufsid for a unique id to identify  
 partitions, like /dev/gptid/xxx, /dev/ufsid/xxx,  update function to  support

Additional Context

Regarding the FreeBSD fstab configuration supporting gptid and ufsid , can refer to these two links
ufsid
gptid

@holmanb holmanb requested a review from igalic April 1, 2024 17:17
@holmanb holmanb added the CLA not signed The submitter of the PR has not (yet) signed the CLA label Apr 1, 2024
@holmanb
Copy link
Member

holmanb commented Apr 1, 2024 •
edited
Loading

@jinkkkang thanks for this PR, can you please sign the CLA and then add yourself to the signers file?

@holmanb holmanb self-assigned this Apr 1, 2024
@jinkkkang
Copy link
Contributor Author

@jinkkkang thanks for this PR, can you please sign the CLA and then add yourself to the signers file?

have signed，thanks

@holmanb holmanb removed the CLA not signed The submitter of the PR has not (yet) signed the CLA label Apr 2, 2024
@jinkkkang
Copy link
Contributor Author

fixed error of lint check

igalic
igalic approved these changes Apr 3, 2024
View reviewed changes
Copy link
Collaborator

@igalic igalic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! Thank you for the contribution!

apparently, AWS (without ZFS) uses this form:

ec2-user@freebsd:~ $ glabel status -s
                                gpt/bootfs  N/A  nda0p1
gptid/053c5311-7fcb-11ee-a7ba-002590ec5bf2  N/A  nda0p1
                                gpt/efiesp  N/A  nda0p2
                                gpt/rootfs  N/A  nda0p3

@holmanb holmanb added the CLA signed The submitter of the PR has signed the CLA label Apr 3, 2024
holmanb
holmanb approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@holmanb holmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks and welcome to cloud-init @jinkkkang!

@jinkkkang jinkkkang requested a review from igalic April 7, 2024 02:50
@holmanb holmanb merged commit 42becf1 into canonical:main Apr 8, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holmanb holmanb holmanb approved these changes

@igalic igalic Awaiting requested review from igalic

Assignees

@holmanb holmanb

Labels
CLA signed The submitter of the PR has signed the CLA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jinkkkang @holmanb @igalic