Do not hardcode reboot command #5208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempting a `cloud-init clean --reboot` fails on alpine because this command is hard-coded. This code already has an Init object available, which has a Distro attribute. Stamp out the duplicate hard-coded implementation and re-use distro reboot code to acquire cross-distro compatiblity. Error: Could not reboot this system using "['shutdown', '-r', 'now']": Unexpected error while running command. Command: ['shutdown', '-r', 'now'] Exit code: - Reason: [Errno 2] No such file or directory: b'shutdown' Stdout: - Stderr: -
|
I guess I've never tried a |
It's honestly not much of a value add, so I'm not terribly surprised. I like it because it shaves off a command when iterating for development and it gets used a fair amount in integration testing so I figure it's worth supporting for all distros. |
TheRealFalcon
approved these changes
Apr 30, 2024
tests/unittests/test_traceback.py
Outdated
| @@ -0,0 +1,9 @@ | |||
| import pytest | |||
There was a problem hiding this comment.
What's the point of this file?
There was a problem hiding this comment.
That was a mistake. Thanks, I'll drop this file.
TheRealFalcon
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Context
This change is mostly test updates - the code change is trivial: just reuse the existing reboot code which already has multi-distro support.