azure: add request identifier to IMDS requests #5218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KsenijaS
force-pushed
the
ksstanoj-imds-headers
branch
from
f679ef0
to
72c603b
Compare
cjp256
reviewed
Apr 29, 2024
cjp256
reviewed
May 3, 2024
5 tasks
holmanb
pushed a commit
that referenced
this pull request
Jun 5, 2024
… readurl() (#5298) My previous change #5218 introduced a bug where IMDS request is missing `Cloud-Init` UserAgent and contains `python-requests` UserAgent instead. A review showed that no users of `headers_cb` were specifying user-agent and it seems unexpected that it wouldn't be defined similar to users of `headers`. This PR updates readurl() to specify User-Agent in `req_args` for users passing in `headers_cb`.
holmanb
pushed a commit
that referenced
this pull request
Jun 28, 2024
Set x-ms-client-request-id uuid per request and log it. This way we can easily find the request in the IMDS logs based on the uuid number.
holmanb
pushed a commit
that referenced
this pull request
Jun 28, 2024
… readurl() (#5298) My previous change #5218 introduced a bug where IMDS request is missing `Cloud-Init` UserAgent and contains `python-requests` UserAgent instead. A review showed that no users of `headers_cb` were specifying user-agent and it seems unexpected that it wouldn't be defined similar to users of `headers`. This PR updates readurl() to specify User-Agent in `req_args` for users passing in `headers_cb`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set x-ms-client-request-id uuid per request and log it.
This way we can easily find the request in the IMDS logs based on the uuid number.