test: Run Alpine tests without network #5220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
TheRealFalcon
force-pushed
the
alpine
branch
5 times, most recently
from
d719c4f
to
6c75316
Compare
|
Requires #5210 or a more creative solution |
Just needs a rebase on main then, right? |
None of the unit tests should be reaching out to the network. Since Alpine tests run under LXD, we can still easily run tests there without network. Also, include the tzdata package that was missed in 725f5fb and remove unneeded network debug lines.
Apparently not. 😄 |
|
@holmanb should be good now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Additional Context
See #5212 (review)
Merge type