fix(net): klibc ipconfig PROTO compatibility #5437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klibc's ipconfig format [1] states that PROTO values 'none', 'off', 'static' and blank all mean no autoconfiguration, but cloud-init parser is too strict and accepts only the first. Fixes LP#2065787 [1] https://git.kernel.org/pub/scm/libs/klibc/klibc.git/plain/usr/kinit/ipconfig/README.ipconfig
|
do I need to sign the CLA even if I'm a member of the @canonical org? |
a-dubs
added
the
CLA not signed
|
Thank you for contributing! And yes, you still need to sign the CLA. |
|
ok, I signed the CLA |
holmanb
added
CLA signed
holmanb
approved these changes
Jun 27, 2024
holmanb
pushed a commit
that referenced
this pull request
Jun 28, 2024
klibc's ipconfig format [1] states that PROTO values 'none', 'off', 'static' and blank all mean no autoconfiguration, but cloud-init parser is too strict and accepts only the first. LP: #2065787 [1] https://git.kernel.org/pub/scm/libs/klibc/klibc.git/plain/usr/kinit/ipconfig/README.ipconfig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
klibc's ipconfig format [1] states that PROTO values 'none', 'off', 'static' and blank all mean no autoconfiguration, but cloud-init parser is too strict and accepts only the first.
LP: #2065787
[1] https://git.kernel.org/pub/scm/libs/klibc/klibc.git/plain/usr/kinit/ipconfig/README.ipconfig