-
Notifications
You must be signed in to change notification settings - Fork 881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new helper, refactor utility functions into separate module #5573
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice refactor! I left a few nits, and a "make sure this is fine" inline, but nothing blocking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few small docstring only changes requested but looks good otherwise! nice refactor, sir holman.
@TheRealFalcon @a-dubs Thanks for the reviews! |
Anything for you, @holmanb |
Additional Context
This PR changes no functionally in cloud-init. It adds a small helper (4 LOC, excluding docstring). The intent for this helper was mentioned here.
Test Steps
Merge type