Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schema): Allow for locale: false in schema add tests #5647

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

blackboxsw
Copy link
Collaborator

Proposed Commit Message

fix(schema): Allow for locale: false in schema add tests


Also refactor and pytestify tests dropping use of
FilesystemMockingTestCase.

Additional Context

Test Steps

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

@github-actions github-actions bot added the documentation This Pull Request changes documentation label Aug 30, 2024
@holmanb holmanb self-assigned this Aug 30, 2024
Also refactor and pytestify tests dropping use of
FilesystemMockingTestCase.
@holmanb
Copy link
Member

holmanb commented Sep 4, 2024

@blackboxsw it looks like this is still failing tests

Copy link
Member

@holmanb holmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the test cleanups!

@blackboxsw blackboxsw merged commit ddb62cc into canonical:main Sep 18, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This Pull Request changes documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants