Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaleway: Force on-link: true for static networks (#5523) #5654

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

karibou
Copy link
Contributor

@karibou karibou commented Sep 2, 2024

On some distributions like focal (See LP: #2073869) systemd fails to add a route which is not in the subnet of the NIC if onlink is not explicitely specified.

Force on-link to true to avoid those situations.
Fixes: GH-5523

Proposed Commit Message

Scaleway: Force on-link: true for static networks (#5523)

<type>(optional scope): <summary>  Force use of on-link: true not working on Ubuntu Focal

The version of systemd on Ubuntu Focal does not support subnets outside
of the NIC network without addition of on-link. This is not the case with other Ubuntu
distributions.

Fixes GH-5523
LP: #2073869

## Merge type

- [x] Squash merge using "Proposed Commit Message"
- [ ] Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

@TheRealFalcon
Copy link
Member

@karibou , thanks for this PR. The changes look good to me, though it conflicts with a PR that was just landed. Would you be able to rebase?

@TheRealFalcon TheRealFalcon self-assigned this Sep 3, 2024
@karibou karibou force-pushed the force_onlink_to_true_in_DS branch 2 times, most recently from f144ded to edd1a02 Compare September 16, 2024 09:19
@karibou
Copy link
Contributor Author

karibou commented Sep 16, 2024

Hello @TheRealFalcon ,

Sorry for the delay, I didn't see your update.

Rebase is done with a fixed unittest.

On some distributions like focal (See LP: #2073869) systemd fails to add
a route which is not in the subnet of the NIC if onlink is not explicitely
specified.

Force on-link to true to avoid those situations.
Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TheRealFalcon TheRealFalcon merged commit 1c61f3f into canonical:main Sep 16, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cloud-init 24.2-0ubuntu1 : Netplan Renderer is not rendering onlink:true when gateway outside of subnet
2 participants