test: assert that schema is valid by default #5657
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Additional Context
This should increase our test coverage of
cloud-init schema
by running it by default inverify_clean_boot()
. This command has had numerous tracebacks over the years (I just reported another), so additional coverage should hopefully help prevent this type of thing from getting hit by users.My plan is to fix any new test failures caused by this new addition prior to adding
verify_clean_boot()
next to ourverify_clean_log()
calls - which should pave the way for eventually replacingverify_clean_log()
.Note: In a followup PR I plan to add new flags (
ignore_deprecations
andrequire_deprecations
) to allow skipping deprecation on tests which we intend to continue using deprecated keys and requiring a deprecation to be reported in the case where it should be.Test Steps
Merge type