Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: assert that schema is valid by default #5657

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

holmanb
Copy link
Member

@holmanb holmanb commented Sep 3, 2024

Proposed Commit Message

test: assert that schema is valid by default

Additional Context

This should increase our test coverage of cloud-init schema by running it by default in verify_clean_boot(). This command has had numerous tracebacks over the years (I just reported another), so additional coverage should hopefully help prevent this type of thing from getting hit by users.

My plan is to fix any new test failures caused by this new addition prior to adding verify_clean_boot() next to our verify_clean_log() calls - which should pave the way for eventually replacing verify_clean_log().

Note: In a followup PR I plan to add new flags (ignore_deprecations and require_deprecations) to allow skipping deprecation on tests which we intend to continue using deprecated keys and requiring a deprecation to be reported in the case where it should be.

Test Steps

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

Copy link
Contributor

@aciba90 aciba90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@holmanb holmanb merged commit 60a856a into canonical:main Sep 4, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants