Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: systemd shutdown ordering #5659

Closed
wants to merge 1 commit into from

Conversation

holmanb
Copy link
Member

@holmanb holmanb commented Sep 3, 2024

Proposed Commit Message

fix: systemd shutdown ordering

This allows cloud-init to be stopped prior to completion so that shutdown may begin. Without Before=shutdown.target, shutdown of the system will be blocked until cloud-init has completed.

Also remove duplicate Conflicts=shutdown. Note that the Conflicts= and Before= dependencies on shutdown.target are the default behaviors, so even if distros set DefaultDependencies=yes this will cause no harm.

man 7 systemd.special

Additional Context

Test Steps

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

This allows cloud-init to be stopped prior to completion so that shutdown
may begin. Without Before=shutdown.target, shutdown of the system will be
blocked until cloud-init has completed.

Also remove duplicate Conflicts=shutdown. Note that the Conflicts= and Before=
dependencies on shutdown.target are the default behaviors, so even if
distros set DefaultDependencies=yes this will cause no harm.

man 7 systemd.special
@aciba90
Copy link
Contributor

aciba90 commented Sep 4, 2024

This is a duplicate of #5653.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants