Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubuntu/devel #5668

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Ubuntu/devel #5668

merged 2 commits into from
Sep 5, 2024

Conversation

blackboxsw
Copy link
Collaborator

Fix lintian issues seen on latest build.

  • Shorten the debian/changelog line that is greater than 80 characters
  • Revert the lintian /usr/lib overrides vs /lib for systemd units. We can address this separately when we properly determine why pkg-config is setting /usr/lib/ in some sbuild environments and /lib in others.

W: cloud-init: debian-changelog-line-too-long [usr/share/doc/cloud-init/changelog.Debian.gz:5]
W: cloud-init: mismatched-override systemd-service-file-refers-to-unusual-wantedby-target cloud-init.target [usr/lib/systemd/system/cloud-config.service] [usr/share/lintian/overrides/cloud-init:2]
W: cloud-init: mismatched-override systemd-service-file-refers-to-unusual-wantedby-target cloud-init.target [usr/lib/systemd/system/cloud-final.service] [usr/share/lintian/overrides/cloud-init:3]
W: cloud-init: mismatched-override systemd-service-file-refers-to-unusual-wantedby-target cloud-init.target [usr/lib/systemd/system/cloud-init-local.service] [usr/share/lintian/overrides/cloud-init:4]
W: cloud-init: mismatched-override systemd-service-file-refers-to-unusual-wantedby-target cloud-init.target [usr/lib/systemd/system/cloud-init-main.service] [usr/share/lintian/overrides/cloud-init:5]
W: cloud-init: mismatched-override systemd-service-file-refers-to-unusual-wantedby-target cloud-init.target [usr/lib/systemd/system/cloud-init-network.service] [usr/share/lintian/overrides/cloud-init:6]
W: cloud-init: systemd-service-file-refers-to-unusual-wantedby-target cloud-init.target [lib/systemd/system/cloud-config.service]
W: cloud-init: systemd-service-file-refers-to-unusual-wantedby-target cloud-init.target [lib/systemd/system/cloud-final.service]
W: cloud-init: systemd-service-file-refers-to-unusual-wantedby-target cloud-init.target [lib/systemd/system/cloud-init-local.service]
W: cloud-init: systemd-service-file-refers-to-unusual-wantedby-target cloud-init.target [lib/systemd/system/cloud-init-main.service]
W: cloud-init: systemd-service-file-refers-to-unusual-wantedby-target cloud-init.target [lib/systemd/system/cloud-init-network.service]

Proposed Commit Message

<type>(optional scope): <summary>  # no more than 72 characters

A description of what the change being made is and why it is being
made if the summary line is insufficient.  This should be wrapped at
72 characters.

If you need to write multiple paragraphs, feel free.

Fixes GH-NNNNN (GitHub Issue number. Remove line if irrelevant)
LP: #NNNNNN (Launchpad bug number. Remove line if irrelevant)

Additional Context

Test Steps

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last sub-bullet of the changelog entry mentioning /usr/lib should be removed too, right? Otherwise, LGTM

@blackboxsw
Copy link
Collaborator Author

thx fixed

@blackboxsw blackboxsw merged commit f472948 into canonical:ubuntu/devel Sep 5, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants