Improve verify_clean_boot()

[holmanb]

Additional Context

See commit messages for details.

verify_clean_boot()

• add support for deprecated calls
• verify cloud-init status return code

Also add verify_clean_boot() alongside each verify_clean_log() call.

Test Steps

Merge type

• Squash merge using "Proposed Commit Message"
• Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

[TheRealFalcon]

One inline call needs to be updated along with a future suggestion, but otherwise LGTM.

[TheRealFalcon]

This feels overly cumbersome for the caller and feels slightly worse than what we had before. Ideally, we'd have some function like verify_schema_deprecations(version="22.2", messages=[...]). That could probably be folded into verify_clean_boot(), but it makes more sense as a separate function to me. I don't think it's a blocker for this PR, but I think there's still more work that can be done here.

[holmanb]

Agreed. This pattern repeats itself a couple of times in tests and I'd love to make testing this easier.

That could probably be folded into verify_clean_boot(), but it makes more sense as a separate function to me.

+1 - Trying to pack that functionality into verify_clean_boot()'s signature would make the signature too messy and take on more scope than I'd like it to. In cases like this it would be cleaner / simpler to verify_clean_boot(ignore_deprecations=True) and then use a helper like you suggest.

[holmanb]

I don't think it's a blocker for this PR, but I think there's still more work that can be done here.

Agreed, this is is a rough edge that I'd love to make more ergonomic. I might try to tackle that in a follow-up PR sometime soon.

[TheRealFalcon]

LGTM!