Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix tip-ruff #5676

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Conversation

TheRealFalcon
Copy link
Member

@TheRealFalcon TheRealFalcon commented Sep 6, 2024

Proposed Commit Message

chore: fix tip-ruff

Additional Context

https://github.com/canonical/cloud-init/actions/runs/10739858604/job/29786611496

Test Steps

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

@TheRealFalcon TheRealFalcon changed the title chore: fix ruff-tip chore: fix tip-ruff Sep 6, 2024
Copy link
Member

@holmanb holmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@holmanb
Copy link
Member

holmanb commented Sep 6, 2024

Aside: we could also bump ruff to prevent more failures from being re-added, but since this code doesn't see much churn I'm not too worried about it

@TheRealFalcon TheRealFalcon merged commit 7a750e3 into canonical:main Sep 6, 2024
21 checks passed
@TheRealFalcon TheRealFalcon deleted the fix-ruff-tip branch September 6, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants