Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: make verify_clean_boot respect return code by series #5695

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

holmanb
Copy link
Member

@holmanb holmanb commented Sep 11, 2024

Proposed Commit Message

test: make verify_clean_boot respect return code by series

Also update stdout / stderr output format.

Additional Context

Failing in https://github.com/canonical/cloud-init/actions/runs/10819125394/job/30016291006?pr=5691

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@holmanb holmanb force-pushed the holmanb/verify_clean_boot_rc branch 3 times, most recently from dcd9e8f to 39939e5 Compare September 12, 2024 22:34
@holmanb
Copy link
Member Author

holmanb commented Sep 12, 2024

@TheRealFalcon @a-dubs I just re-requested review, because I had to fix the failing tests. This fix is kinda funky, but basically our integration tests are unpatched, so despite running on focal, they behave like they are running on Noble, so CURRENT_RELEASE doesn't tell us everything that we need to know. This should only really be a problem on main, which is why I think it's safe to do it this way.

@holmanb holmanb merged commit a9c6b14 into canonical:main Sep 13, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants