fix: force sftp cleanup when done with instance #5698
Conversation
Force inline sftp closure rather than on garbage collection. Without this, pytest causes tracebacks because it cleans up the logger before the final sftp connection is closed, which causes tracebacks after tests pass.
| # paramiko to barf when it logs that the connection is being closed. | ||
| # | ||
| # Manually run __del__() to prevent this teardown mess. | ||
| instance.instance.__del__() |
There was a problem hiding this comment.
nit: del instance.instance
There was a problem hiding this comment.
nit: del instance.instance
fyi that's what the original implementation attempted, but it didn't work because del decrements the refcount, which will not necessarily cause the refcount to go to 0, nor will it force the garbage collector to run (which is what invokes __del__()). This really deserved a comment, but since this is somehow happening in CI still, further investigation is required
|
However this weirdly didn't seem to fix the issue in ci (this test run still had the traveback despite passing) and I wasn't able to repro locally with this fix so more digging is required |
I'm going to merge this since it resolves the issue locally, I may followup to resolve the issue in CI as well. |
Proposed Commit Message
Additional Context
pytest-dev/pytest#5282
pytest-dev/pytest#5502
canonical/pycloudlib#415
Test steps
I tested the
clientandclass_clientfixtures manually by introducing two new classes, with one failing test each, and didn't see any tracebacks nor unexpected failures.