fix: Invalid "seedfrom" in NoCloud system configuration #5701

TheRealFalcon · 2024-09-13T00:57:31Z

Proposed Commit Message

Use individual commits

First commit is just pytestifying the tests so I can later use the caplog fixture.

Squash merge using "Proposed Commit Message"
Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

blackboxsw · 2024-09-13T03:04:49Z

tests/unittests/sources/test_nocloud.py

+@pytest.fixture
+def paths(tmpdir):
+    yield helpers.Paths({"cloud_dir": tmpdir, "run_dir": tmpdir})


We already have a paths fixture in the top-level conftest.py so no need to reinvent here.

blackboxsw

thanks for the additional test coverage here asserting that sys_config files can still provide NoCloud.seedfrom urls.

TheRealFalcon · 2024-09-13T03:45:26Z

+1 to your change

TheRealFalcon requested a review from holmanb September 13, 2024 00:57

TheRealFalcon force-pushed the nocloud-typo branch 2 times, most recently from f266f34 to dc80de5 Compare September 13, 2024 01:31

blackboxsw reviewed Sep 13, 2024

View reviewed changes

blackboxsw force-pushed the nocloud-typo branch 2 times, most recently from df06fdb to f809d7d Compare September 13, 2024 03:16

blackboxsw approved these changes Sep 13, 2024

View reviewed changes

TheRealFalcon added 2 commits September 13, 2024 10:51

tests: pytestify test_nocloud.py (canonical#5701)

d3f920f

fix: Invalid "seedfrom" in NoCloud system configuration (canonical#5701)

d87411b

TheRealFalcon force-pushed the nocloud-typo branch from f809d7d to d87411b Compare September 13, 2024 15:52

TheRealFalcon merged commit 2c80c5a into canonical:main Sep 13, 2024
21 checks passed

TheRealFalcon added a commit that referenced this pull request Sep 13, 2024

tests: pytestify test_nocloud.py (#5701)

aad5286

TheRealFalcon deleted the nocloud-typo branch September 13, 2024 15:58