fix: lxd do not check for thinpool kernel module #5709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than checking for kernel module file before running lxd, just fall back to disabling thinpool and retrying with thinpool disabled when cloud-init fails and it is using lvm as backing storage. On some Ubuntu releases, the kernel module is compressed which causes this check to fail and this warning to erroneously be logged.
holmanb
force-pushed
the
holmanb/lxd-thinpool
branch
from
6e53cb6
to
1b0aa5a
Compare
holmanb
added a commit
to holmanb/cloud-init
that referenced
this pull request
Sep 17, 2024
Rather than checking for kernel module file before running lxd, just fall back to disabling thinpool and retrying with thinpool disabled when subp() fails and it is using lvm as backing storage. On some Ubuntu releases, the kernel module is compressed which causes this check to fail and this warning to erroneously be logged. Making this logic only run in the failure path and avoiding file matches on kernel driver files should be less error prone. BREAKING_CHANGE: On some Ubuntu series this changes behavior causing lxd to now use lxd thinpool, which is the current lxd default. LP: #1982780
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Additional Context
Some images ship compressed kernel modules. On Jammy, GCE, we ship:
/lib/modules/6.8.0-1014-gcp/kernel/drivers/md/dm-thin-pool.ko.zsthttps://jenkins.canonical.com/server-team/view/cloud-init/job/cloud-init-integration-noble-gce/lastCompletedBuild/testReport/
Test Steps
Merge type