Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix typing of userdata_raw #5710

Merged
merged 1 commit into from
Sep 17, 2024
Merged

chore: fix typing of userdata_raw #5710

merged 1 commit into from
Sep 17, 2024

Conversation

TheRealFalcon
Copy link
Member

Proposed Commit Message

chore: fix typing of userdata_raw

Additional Context

Test Steps

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

a-dubs
a-dubs approved these changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@a-dubs a-dubs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉 🎉

holmanb
holmanb reviewed Sep 17, 2024
View reviewed changes
Copy link
Member

@holmanb holmanb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is a bytes object assigned to self.userdata_raw? Does this resolve some mypy warnings in one of our ignored files?

@holmanb holmanb self-assigned this Sep 17, 2024
@TheRealFalcon
Copy link
Member Author

TheRealFalcon commented Sep 17, 2024 •
edited
Loading

Where is a bytes object assigned to self.userdata_raw?

Not sure all the places, but userdata_raw is bytes when using NoCloud. Probably a few other datasources too.

Does this resolve some mypy warnings in one of our ignored files?

No, it'll probably add more tbh 😄

@TheRealFalcon TheRealFalcon merged commit df75b52 into canonical:main Sep 17, 2024
21 checks passed
@TheRealFalcon TheRealFalcon deleted the raw-type branch September 17, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-dubs a-dubs a-dubs approved these changes

@holmanb holmanb holmanb approved these changes

Assignees

@holmanb holmanb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheRealFalcon @holmanb @a-dubs